search

berlinguyinca / spectra-hash

The splash, this is the reference documentation
http://splash.fiehnlab.ucdavis.edu
BSD 3-Clause "New" or "Revised" License
23 stars 11 forks source link

Java library not compatible with Java 7 #26

Closed tomas-pluskal closed 8 years ago

tomas-pluskal commented 8 years ago

Hi, It seems the Java (Scala) classes deployed to the Fiehn lab's maven repository are compiled with Java 8 as target version. Is there any reason for that? Could you change it to Java 7 and release an updated version? Thanks, Tomas

berlinguyinca commented 8 years ago

Dear all

Sorry we stopped supporting java 7 a while ago. Could you just wrap the rest api. If you really need 7 support?

Thanks G. On May 14, 2016 4:07 PM, "Tomáš Pluskal" notifications@github.com wrote:

Hi, It seems the Java (Scala) classes deployed to the Fiehn lab's maven repository are compiled with Java 8 as target version. Is there any reason for that? Could you change it to Java 7 and release an updated version? Thanks, Tomas

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/berlinguyinca/spectra-hash/issues/26

tomas-pluskal commented 8 years ago

It is for MSDK, which is declared as Java 7-friendly. Using the REST API is not practical for MSDK.

If no Java 8-specific API is used in the SPLASH code, wouldn't it be a matter of just changing one entry in the pom.xml?

berlinguyinca commented 8 years ago

The problem is that the patent pom of the splash is used in dozens of other projects and so we can't just change it. I look a bit more into it next week. If we can adjust it.

G. On May 14, 2016 4:44 PM, "Tomáš Pluskal" notifications@github.com wrote:

It is for MSDK, which is declared as Java 7-friendly. Using the REST API is not practical for MSDK.

If no Java 8-specific API is used in the SPLASH code, wouldn't it be a matter of just changing one entry in the pom.xml?

— You are receiving this because you commented.

Reply to this email directly or view it on GitHub https://github.com/berlinguyinca/spectra-hash/issues/26#issuecomment-219257766

tomas-pluskal commented 8 years ago

It is possible to override the child pom's java version without modifying the parent. See here: http://stackoverflow.com/questions/1771561/maven-is-it-possible-to-override-the-configuration-of-a-plugin-already-defined

berlinguyinca commented 8 years ago

Would you like todo this? I think you have commit rights.

G. On May 14, 2016 6:17 PM, "Tomáš Pluskal" notifications@github.com wrote:

It is possible to override the child pom's java version without modifying the parent. See here: http://stackoverflow.com/questions/1771561/maven-is-it-possible-to-override-the-configuration-of-a-plugin-already-defined

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/berlinguyinca/spectra-hash/issues/26#issuecomment-219260529

tomas-pluskal commented 8 years ago

Sure! I'll send a pull request.

tomas-pluskal commented 8 years ago

See PR #27