berman-lab / ymap

YMAP - Yeast Mapping Analysis Pipeline : An online pipeline for the analysis of yeast genomic datasets.
MIT License
6 stars 6 forks source link

Combining figures with new datasets requires pressing the combine button again #46

Closed vladimirg closed 8 years ago

vladimirg commented 8 years ago

Prerequisite - begin with at least 3 datasets of the same genome (for testing).

  1. Choose two datasets.
  2. Click "Combine figures viewed below.".
  3. Choose any option (e.g., CNV).
  4. Add another deselect (one of the previous dataset can be deselected).
  5. Pressing any option from the menu in #3 then presents the combination of the previously selected datasets, not the current one.
  6. Press the "Combine figures viewed below." button again.
  7. The combination options now work as expected.

Possibly the datasets to combine are chosen exactly at the moment of the pressing of the "combine" button, which is very unintuitive.

vladimirg commented 8 years ago

Fixed by a workaround of sorts - now every time the dataset list changes (a user selects or deselects a dataset) the combined figure menu will be hidden, forcing the user to click the button, forcing a re-generation of the combined figures. Insures the combined figures match the ones actually displayed.