search

bermudalocket / Tweaks-for-Reddit

A Safari App Extension to help make Reddit suck just a little less on Safari 13+. Written (mostly) in SwiftUI.
GNU General Public License v3.0
114 stars 9 forks source link

Scaling issue with popover menu with large custom subreddit list #19

Closed Pinatata closed 3 years ago

Pinatata commented 3 years ago

I'm having issues using the popover menu once the custom subreddit list becomes large. I can't scroll up/down to see the other elements in the popover menu.

Not sure if there's a way to add scrolling within the popover menu. Otherwise, it may be better to explore different menu structures. For example, I notice Dark Reader's settings take me different page that is still displayed in the popover menu.

Tweaks for Reddit Popover issue

Screen Shot 2021-05-09 at 1 56 49 PM

Dark Reader Settings Example

Screen Shot 2021-05-09 at 2 04 51 PM Screen Shot 2021-05-09 at 2 04 58 PM
bermudalocket commented 3 years ago

Oh, that's no good. I know exactly why it's happening, though: https://github.com/bermudalocket/Tweaks-for-Reddit/blob/88bf11f5078828e14e46c911e5985f67499b3f67/redditweaks%20Extension/View/FavoriteSubredditsSectionView.swift#L72

I will explore options and push a fix to the Mac App Store.

bermudalocket commented 3 years ago

Version 1.10 fixes this and adds some customizability. It should push to the Mac App Store tomorrow, Friday, May 14.

Pinatata commented 3 years ago

Just got the 1.10 update on my end. The custom subreddit list scrolling looks perfect! However, the entire menu still has some scaling issues on my end. In fact, I noticed 2 different behaviors:

  1. When in full-screen or desktop mode

    Screen Shot 2021-05-16 at 9 06 56 AM

  2. When in full-screen and menu bar comes down

    Screen Shot 2021-05-16 at 9 07 03 AM

    (menu bar isn't in the screenshot but it is down)