search

bernabe9 / redux-react-session

:key: Simple Session API storage for Redux and React
https://bernabe9.github.io/redux-react-session/
147 stars 41 forks source link

Fix react-router-v4-example. Use prop-types package. Update dependencies. Add package-lock files. #11

Closed umpc closed 7 years ago

umpc commented 7 years ago

I got the following error when I tried to run the react-router-v4-example:

tools/server.js:3
import path from 'path';
^^^^^^

SyntaxError: Unexpected token import

To get it working properly, I updated the dependencies, one appeared to be broken, and then fixed a few bugs that were still breaking the example.

The example now uses PropTypes from the prop-types package, as importing PropTypes from the react package has been deprecated.

I also committed package-lock.json files, which are part of the new npm version 5, and are suggested to be committed by the npm utility.

Thank you for this helpful package with examples!

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 98.425% when pulling b6866f6be667f1fdc3b0d3a4873359e11442ebc4 on umpc:master into f5e9f9aadb8df7100f46e0ba2985586db6cafc37 on bernabe9:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 98.425% when pulling 15f856867f11eb6e9d0b81aa8af0bd44582ef2d3 on umpc:master into f5e9f9aadb8df7100f46e0ba2985586db6cafc37 on bernabe9:master.

umpc commented 7 years ago

I've added your suggestion. Thank you for considering (and improving) the changes!