bernabe9 / redux-react-session

:key: Simple Session API storage for Redux and React

https://bernabe9.github.io/redux-react-session/

147 stars 41 forks source link

Return promise in initSessionService #18

Closed hitochan777 closed 6 years ago

hitochan777 commented 6 years ago

Changes

initSessionService now returns promise
refreshFromLocalStorage also returns promise sessionService.loadUser().then(...) to guarantee that user is set to the redux state when the promise returned by initSessionService is resolved.
beforeAll in index.spec.js calls done when the promise is resolved, instead of subscribing to redux store.

hitochan777 commented 6 years ago

@bernabe9 I noticed that __setSession, __setUser and __setError modifies the global variables in localforage.js but you did not initialize them before each test. Maybe we should do so in order to make all the tests independent of the previous tests? Or did you do this intentionally for some reason? Thanks!

coveralls commented 6 years ago

Coverage remained the same at 97.842% when pulling dc3609084cd6a8294e201ffd4dfaaa3ac57ddf62 on hitochan777:return-promise into f3566ddb46cc097687e49190c19d6ddc887c2998 on bernabe9:master.

bernabe9 commented 6 years ago

Good work 💪

About the global variables in the tests you're right, we should initialize them before each test. So, maybe we could open a new PR later to improve those test.

hitochan777 commented 6 years ago

@bernabe9 thanks for merging my PR! Yeah, definitely. we can work on it together.