bernaferrari / GradleKotlinConverter

Convert from Groovy to Kotlin DSL for Gradle, focused on Android.
https://gradle-kotlin-converter.vercel.app
Apache License 2.0
921 stars 61 forks source link

Fix common non-major bugs #36

Closed IslamSalah closed 3 years ago

IslamSalah commented 3 years ago

Overview

On using this script to migrate around 50 Groovy Gradle files to Kotlin, it was really helpful. However some conversion bugs were discovered. It was easier fixing the bugs in the script logic rather than manually repeating them among all the converted files. The issues fixed are listed below

Type of change:

Bug fixes

What's the purpose of this PR?

Fix bugs found in conversion logic

N.B Commit by commit review can be helpful

What is the impact of this change?

More reliable output by the script

List of Groovy input giving wrong output before this proposed change:

bernaferrari commented 3 years ago

Awesome to hear! Thanks!

bernaferrari commented 2 months ago

You once helped me. I refactored the project into this website: https://gradle-kotlin-converter.vercel.app/