search

bernard-lin / babel-plugin-glamorous-displayname

A babel plugin for Glamorous displayNames 💄
http://npm.im/babel-plugin-glamorous-displayname
MIT License
32 stars 2 forks source link

Turn this into a babel-macros plugin #11

Closed kentcdodds closed 6 years ago

kentcdodds commented 6 years ago

babel-macros is a new thing that I made and I think it's pretty great. I'm going to create glamorous.macro and port this over to that.

bernard-lin commented 6 years ago

Sounds good!

kentcdodds commented 6 years ago

If you'd like, we can still use this repo and just rename it. I can do all the work on it and just push my stuff in a PR when I'm done :smile: However you want to do it.

bernard-lin commented 6 years ago

Whatever is easiest for you! 😀

kentcdodds commented 6 years ago

lol, I just realized that this is one situation where it wont work as a babel-macros macro 🙃 I guess I'm still getting used to the use cases myself!

kentcdodds commented 6 years ago

If you're curious, the reason why is a macro plugin must be imported to be applied:

import glamorousMacro from 'glamorous.macro'

But people will be importing glamorous not glamorous.macro 😅

bernard-lin commented 6 years ago

Ahh makes sense. Excited to see what kind of macros people come up with though!