search

bernardboey / pe

0 stars 0 forks source link

Sequence diagram does not have activation bar for self-invocation #11

Open bernardboey opened 2 years ago

bernardboey commented 2 years ago

As seen below, when the Registration object calls Verifier#setSuccessfullySignedIn(false), there is no activation bar for the self-invocation, which is not compliant with the notation learnt in CS2113/T. It looks confusing as it looks as though the Registration object is returning twice with the 2 arrows.

image.png

soc-se-bot commented 2 years ago

Team's Response

As stated here

image.png

We think that this does not lead to any loss of information/ambiguity. Furthermore, it reduces clutter too.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: As explained earlier, it looks confusing as it looks as though the Registration object is returning twice with the 2 arrows. If the reader is well acquainted with UML notation (e.g. difference between dashed and solid arrows), and takes the time to carefully scrutinize the diagram, they would probably understand what the author intended. However, at a glance, it is confusing, and it is better to include the activation bar for the self-invocation.