search

bernardboey / pe

0 stars 0 forks source link

Sequence Diagram does not have activation bar for SignInDetailsParser #12

Open bernardboey opened 2 years ago

bernardboey commented 2 years ago

As seen below, there is a missing activation bar for SignInDetailsParser, which is not compliant with the notation learnt in CS2113/T. Which method is calling the methods getNewSalt(), generatePasswordHash(), etc.? Only the activation bar for the self-invocation (checkUserRole()) is shown.

image.png

soc-pe-bot commented 2 years ago

Team's Response

This actually follows the notation for reference frames shown on the module website.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]