search

bernardboey / pe

0 stars 0 forks source link

Modifying meetings storage file to a timing that the user is not available for is allowed #8

Open bernardboey opened 2 years ago

bernardboey commented 2 years ago

Steps to reproduce:

  1. Open the meetings.txt file
  2. Modify the timing to a timing that the user is not available for
    • 01-01-2021 | 14:00 | Test Meeting | user,admin -> 01-01-2021 | 18:00 | Test Meeting | user,admin

This is a legitimate use case for advanced users.

Expected:

An error message indicating that the user is not available at that timing

Actual:

The meeting is shown as per normal.

image.png

nus-se-bot commented 2 years ago

Team's Response

Referring to the cOOPer's Storage section in the User Guide, you should not edit the storage files. Advanced users are not an exception to this instruction.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Providing the warning to not edit storage files is not an excuse to handle potential errors with the storage file. One of the constraints for TP is that the file should be human editable to allow advanced user to manipulate data by editing the data file.

image.png

Additionally, according to Prof Akshay in this forum post, the warning to not edit the file will not be honored. As stated on the website, for the PE, we are allowed to deviate from the instructions.

image.png