bernardodionisi / differences

difference-in-differences in Python
https://bernardodionisi.github.io/differences/latest/
GNU General Public License v3.0
93 stars 21 forks source link

Wald Pre-Test Issue #16

Open lilygordonn opened 9 months ago

lilygordonn commented 9 months ago

When using the wald_pre_test property, I get the following error: TypeError: results() got an unexpected keyword argument 'sample_name.'

It points to this line as the error, so I am not sure if there is something wrong with the property: File ~/opt/anaconda3/lib/python3.9/site-packages/differences/attgt/attgt.py:1089, in ATTgt.wald_pre_test(self) 1087 _wald_pre_test = {} 1088 for s in self.sample_names: -> 1089 res = self.results(sample_name=s) 1090 res = wald_pre_test(res) 1092 if s == "full_sample":

bernardodionisi commented 5 months ago

Hi, I apologize I missed this issue, I have not checked in for a while. I will try to take a look soonish