Fixes #443
The system check best_practice gets a list of INSTALLED_APPS from the app_configs parameter but then it compares it with settings.SHARED_APPS and settings.TENANT_APPS. I changed it so that it also uses settings.INSTALLED_APPS instead of using the app_configs parameter.
We had to change this to be able to use Sentry. Sentry's Django AppConfig's name is "raven.contrib.django", but in INSTALLED_APPS (according to the docs) you write "raven.contrib.django.raven_compat".
There's probably a problem in the way the Raven app is configured, since its AppConfig.name should be the full Python path to the app. But I also think that this fix in django-tenant-schemas is in order.
Fixes #443 The system check
best_practicegets a list of INSTALLED_APPS from theapp_configsparameter but then it compares it withsettings.SHARED_APPSandsettings.TENANT_APPS. I changed it so that it also usessettings.INSTALLED_APPSinstead of using theapp_configsparameter.We had to change this to be able to use Sentry. Sentry's Django AppConfig's name is "raven.contrib.django", but in INSTALLED_APPS (according to the docs) you write "raven.contrib.django.raven_compat".
There's probably a problem in the way the Raven app is configured, since its
AppConfig.nameshould be the full Python path to the app. But I also think that this fix indjango-tenant-schemasis in order.What do you think?