bernardopires / django-tenant-schemas

Tenant support for Django using PostgreSQL schemas.

https://django-tenant-schemas.readthedocs.org/en/latest/

MIT License

1.45k stars 424 forks source link

Fixed #648 #641 -- Prevent --skip-checks conflict issue #650

Closed danh91 closed 1 year ago

danh91 commented 4 years ago

648 #641

PR description

https://github.com/bernardopires/django-tenant-schemas/issues/648#issuecomment-671115840

Tested with:

Django=3.1

rj76 commented 4 years ago

When is this going to get merged? I reckon quite some people want this.

AceTugboat commented 4 years ago

Yes please, I too would like this merged in.

OskarPersson commented 4 years ago

ping @bernardopires @goodtune

marktiu commented 4 years ago

👍

amir99 commented 4 years ago

OskarPersson commented 3 years ago

@DanH91 The same exact change is also needed in tenant_schemas/management/commands/tenant_command.py, could you (or maintainer @goodtune or @bernardopires) update this PR to include that too? This would then also close #634 #641 and #648

danh91 commented 3 years ago

@OskarPersson I am more than glad to do it. However, we will need @goodtune or @bernardopires to approve before it makes it in.

OskarPersson commented 3 years ago

Great! Just want to make sure that as much is possible is included (while keeping to the scope of the PR) when it eventually gets merged :)

jeroenbrouwer commented 3 years ago

Wouldn't it be better to check for django version >= 3.1 before setting the requires_system_checks = []?

mo-mughrabi commented 3 years ago

AdamiHamza commented 3 years ago

barrerajl commented 3 years ago

danh91 commented 3 years ago

Hey guys, In addition to migrate_schemas, I made two other commits to fix collectstatic_schemas and tenant_command since they were all affected by the same --skip-checks issue.

@goodtune @bernardopires

crstnrm commented 3 years ago

RuchitMicro commented 3 years ago

Hello is this added ?

thelinuxer commented 3 years ago

My whole django 3.1 upgrade is blocked by this. Can we please merge it ?

rj76 commented 3 years ago

My whole django 3.1 upgrade is blocked by this. Can we please merge it ?

You, and others, might want to merge to django-tenants (https://pypi.org/project/django-tenants/). It's a fork that's actively supported.

RuchitMicro commented 3 years ago

I would suggest people, move from this and go to Django-tenants. It is a fork to Django-tenant-schemas and it's more active.

arvindyadav124 commented 3 years ago

When are we going to merge this? Any timeline, please? @goodtune @bernardopires

amontalban commented 3 years ago

I had to move to django-tenants because of this.

flexabyte commented 3 years ago

Any news on someone with write access to merge this? It appears it's passing all checks and should be fine to merge no?

mast3rbow commented 3 years ago

Agree @flexabyte, kinda stuck on lower Django version waiting for this merge.

jaydipkmn commented 3 years ago

@goodtune and @bernardopires any news on when this is going to get merged ? Its kind of blocker for us.

Hudeh commented 3 years ago

still not working am using django 3.1

chauncy-sue commented 3 years ago

let's do it, i've hold my project for more than 20 years because of this things, my boss cannot wait for somedays he's to0 old to waiting

tomi-bigpi commented 2 years ago

Just a heads up for anyone that's watching just this PR and not current releases - It looks like these changes are in the master branch from the following commits:

...and version 1.11.0 has been released.

I'm assuming that those resolve the issue (haven't tested yet) and this PR could be closed?