search

bernat / best_in_place

A RESTful unobtrusive jQuery Inplace-Editor and a helper as a Rails Gem
http://blog.bernatfarrero.com/in-place-editing-with-javascript-jquery-and-rails-3/
1.2k stars 572 forks source link

Changed data-bip-url to data-url #456

Closed chevinbrown closed 9 years ago

chevinbrown commented 9 years ago

I was getting errors because the data-url attribute was written as data-bip-url. Simply changed helper.rb and spec--all working for me.

stereodenis commented 9 years ago

@chevinbrown tests are red and no changes

stereodenis commented 9 years ago

@chevinbrown 

appraisal rails-4.2 rspec
WARN: Unresolved specs during Gem::Specification.reset:
      rake (>= 0)
      thor (>= 0.14.0)
WARN: Clearing out unresolved specs.
Please report a bug if this causes problems.
>> BUNDLE_GEMFILE=/Users/stereodenis/work/test/best_in_place/gemfiles/rails_4.2.gemfile bundle exec rspec
..........................................................................................................................................................

Finished in 26.54 seconds (files took 2.07 seconds to load)
154 examples, 0 failures
seuros commented 9 years ago

??