Select Collection sorting

[vzelenko]

I am using best_in_place gem for rendering a list of values as so

<%= best_in_place model, :method, as: :select, collection: [ ['', ''], ['4', 'First Item'], ['2', 'Third Item'], ['1', 'Fifth Item'] ] %> The dropdown renders just fine, but the items are sorted by KEY (['1', '2', '4', '']) instead of natural insertion order. Is there any way to change that to be by value?

avdept commented 9 years ago

Having same issue too

stevenspiel commented 9 years ago

also same issue

stevenspiel commented 9 years ago

after investigating, it looks like this has been resolved on master, but not on 3.0.3

vzelenko commented 9 years ago

Ah, that makes sense. I was just looking at master code, and could not find what made it follow the ID order. :)

avdept commented 9 years ago

@vzelenko AFAIU its problem of chrome\opera, not this gem. I've fixed this by setting collection like {"V1":"some value"} instead of {"1":"some_value"}. And on request from input - i remove these strings

stevenspiel commented 9 years ago

:+1:

vzelenko commented 9 years ago

@avdept: Maybe I am wrong, but I need the dropdown sorted in its natural insert order (in my case, by 'value'). The helper somehow reorders it by 'key' instead, at least on the production stable gem version.

avdept commented 9 years ago

@vzelenko check this thread http://stackoverflow.com/questions/11045331/javascript-jquery-parsing-json-in-same-order Same problem here, inside gem, there is JSON.parse(collection), and after parse - browser sorts(no idea why) by key. And to prevent from sorting, made impossible for browser order by key, because my keys were strings "V1" instead of "1"

vzelenko commented 9 years ago

OK, so I have confirmed that MASTER branch has this issue fixed. Tested in Chrome, on macbook pro. Closing the issue.

Thanks everyone for the feedback.

bvogel commented 9 years ago

@seuros Any chance to cut a new release so I don't need to use the master branch? I need this fix...

seuros commented 9 years ago

sure. I will do that today. Thanks for the ping.

codeundercoverdev commented 7 years ago

I am using the master branch and still having this problem. Has anyone fixed it?

• © Githubissues.
• Githubissues is a development platform for aggregating issues.

[avdept]

Having same issue too

[stevenspiel]

also same issue

[stevenspiel]

after investigating, it looks like this has been resolved on master, but not on 3.0.3

[vzelenko]

Ah, that makes sense. I was just looking at master code, and could not find what made it follow the ID order. :)

[avdept]

@vzelenko AFAIU its problem of chrome\opera, not this gem. I've fixed this by setting collection like {"V1":"some value"} instead of {"1":"some_value"}. And on request from input - i remove these strings

[stevenspiel]

:+1:

[vzelenko]

@avdept: Maybe I am wrong, but I need the dropdown sorted in its natural insert order (in my case, by 'value'). The helper somehow reorders it by 'key' instead, at least on the production stable gem version.

[avdept]

@vzelenko check this thread http://stackoverflow.com/questions/11045331/javascript-jquery-parsing-json-in-same-order Same problem here, inside gem, there is JSON.parse(collection), and after parse - browser sorts(no idea why) by key. And to prevent from sorting, made impossible for browser order by key, because my keys were strings "V1" instead of "1"

[vzelenko]

OK, so I have confirmed that MASTER branch has this issue fixed. Tested in Chrome, on macbook pro. Closing the issue.

Thanks everyone for the feedback.

[bvogel]

@seuros Any chance to cut a new release so I don't need to use the master branch? I need this fix...

[seuros]

sure. I will do that today. Thanks for the ping.

[codeundercoverdev]

I am using the master branch and still having this problem. Has anyone fixed it?