Calls new Capybara.default_max_wait_time to surpress deprecation warning

bernat / best_in_place

A RESTful unobtrusive jQuery Inplace-Editor and a helper as a Rails Gem

http://blog.bernatfarrero.com/in-place-editing-with-javascript-jquery-and-rails-3/

1.2k stars 571 forks source link

Calls new Capybara.default_max_wait_time to surpress deprecation warning #523

Closed bcavileer closed 1 year ago

bcavileer commented 8 years ago

Deprecation message: DEPRECATED: #default_wait_time is deprecated, please use #default_max_wait_time instead

This code is probably excessively complicated. I introduced a new configuration option with the goal in mind to remove the hard dependency Capybara.default_wait_time in BestInPlace::TestHelpers#wait_until.

bcavileer commented 8 years ago

This is a pull request for issue https://github.com/bernat/best_in_place/issues/515

drueck commented 8 years ago

Hmm... just realized a large downside to both approaches is that we're adding additional methods to the tests that include these test helpers. Perhaps this configuration should be done in an initializer?