search

bernat / best_in_place

A RESTful unobtrusive jQuery Inplace-Editor and a helper as a Rails Gem
http://blog.bernatfarrero.com/in-place-editing-with-javascript-jquery-and-rails-3/
1.2k stars 570 forks source link

Remove rails 6 deprecations #624

Closed JDrizzy closed 3 months ago

JDrizzy commented 4 years ago

Resolves https://github.com/bernat/best_in_place/issues/623 Resolves https://github.com/bernat/best_in_place/issues/621 & https://github.com/bernat/best_in_place/issues/611

dirkjonker commented 4 years ago

@JDrizzy awesome job. To make the tests pass for Rails 4.2 work you probably need to pin rspec-rails to 3.x. and bundler to 1.x.

dirkjonker commented 4 years ago

By the way, I can confirm that this works with our Rails 5.2 in production. Also works after upgrading to Rails 6 in my development environment.

evanliewer commented 4 years ago

Does it work with web packer?

JDrizzy commented 4 years ago

Does it work with web packer?

I'm currently using it on a production app with webpacker, but the library's assets are still being provided by sprockets, unfortunately.

Amm1r-IT commented 4 years ago

Hi, I'm not sure how to solve the issue. What should I do to make work with rails 6? someone gave me the link to this page but what steps should I take or follow. Any tips?

Thanks,

JDrizzy commented 4 years ago

@Amm1r-IT to use the changes for this PR you can either reference my repository in your gemfile:

gem 'best_in_place', github: 'JDrizzy/best_in_place'

Or, fork your own copy and reference that instead.

Ideally, this PR should be merged so you don't need to complete the above two workarounds but I'm not sure when that will be.

Amm1r-IT commented 4 years ago

Thanks man

dsounded commented 4 years ago

What's the status ?

ArturDatsenko commented 3 years ago

When this PR is planned to be merged?