search

bernat / best_in_place

A RESTful unobtrusive jQuery Inplace-Editor and a helper as a Rails Gem
http://blog.bernatfarrero.com/in-place-editing-with-javascript-jquery-and-rails-3/
1.2k stars 570 forks source link

Fix for Ruby 3.2 support #641

Closed rmm5t closed 3 months ago

rmm5t commented 1 year ago

Fixes #640

adysson commented 7 months ago

@bernat could you please accept this PR? I use best_in_place in one project and would be grateful if we could update your gem for current Ruby and Rails versions..

mdworken commented 5 months ago

Confirmed this PR works. Had to fork the project but confirmed it works as intended, usable with gem "best_in_place", git: "https://github.com/givecampus/best_in_place" (replace with your own repo)

chaadow commented 3 months ago

I think we should tag @seuros hopefully you can merge and release this PR 🙏🏼

seuros commented 3 months ago

We could release a new version. But last time I checked the code , this gem was not not thread safe .

Can someone confirm that it working correctly ?

chaadow commented 3 months ago

I can confirm. as you can see here https://github.com/chaadow/best_in_place

I've been using my own fork in a production app for almost 2 years, and I'm also on rails 8.0.0.alpha and this gem still works properly with my fork ( which has the same changes as this Pull request ) @seuros

( my fork is older than this PR)

seuros commented 3 months ago

Okey then. I will push a release tomorrow.

seuros commented 3 months ago

@chaadow you open a PR to test it against the new rubies and rails and drop support for ruby below 3.1 and rails 7.0.

This will allow having better maintenance in the future.

Thanks for the mention.

chaadow commented 3 months ago

Done in #644