search

bernat / best_in_place

A RESTful unobtrusive jQuery Inplace-Editor and a helper as a Rails Gem
http://blog.bernatfarrero.com/in-place-editing-with-javascript-jquery-and-rails-3/
1.2k stars 570 forks source link

Fix CI [ part 2 ] #645

Closed chaadow closed 3 months ago

chaadow commented 3 months ago

@seuros All good the CI is green!

seuros commented 3 months ago

Thanks for fixing the build.

I tried to fix it from the browser and github went offline haha

seuros commented 3 months ago

Do we need to merge anything or any open PR ?

Else I we can bump major version and release.

chaadow commented 3 months ago

@seuros that's what i'm trying to figure out, just give me an hour or so and I'll let you know

chaadow commented 3 months ago

Thanks for merging!

chaadow commented 3 months ago

@seuros I think we can release for now, everything works on my production app, the most important bits have already been handled in my PR. If need be, we can release other PRs later after they've been rebased and CI is green on them

seuros commented 3 months ago

Released as 4.0.0

chaadow commented 3 months ago

Thanks!