git submodule update --init happens too early

Hi,

I'm attempting to use a git repo as the source of a recipe. I'm using a specific :tag from this repo and there are submodules to be had. It seems easy enough to enable this using :submodule => true, yay!

However, fpm-cookery is attempting to initialize and update the submodules too early, while the git repository is still on the master branch.

ie. It does this

    git clone https://some.where/repo.git
    cd repo
    git submodule update --init
    git checkout -f the_tag

The submodules step happens too early, and may not exist in the master branch, etc. I believe it should do this:

    git clone https://some.where/repo.git
    cd repo
    git checkout -f the_tag
    git submodule update --init

Now you should have the correct submodules for the tag that was checked out.

Currently, this can be worked around using an after_source_download hook with content along the lines of:

    Dir.chdir cachedir/name do
        sh "git checkout #{name}-#{version}" # Or whatever your tag is
        sh "git submodule update --init"
    end

It must be done at this stage since after this the source is "extracted" (copied) over to the builddir without the .git repo.

Cheers,

bernd / fpm-cookery

git submodule update --init happens too early #144