Closed tomeon closed 8 years ago
Hm, looks like the Travis build for Ruby 1.9 failed due to https://github.com/jordansissel/fpm/pull/1146 / https://github.com/jordansissel/fpm/issues/1147? Not entirely certain -- looking at the bundle install
output in the Travis build console, I don't see any mention of fpm
itself, just json
.
Thank you!
I hit an issue building a package with an updated revision -- because the extact cookie from a previous build with a different revision number was still hanging around, fpm-cookery didn't copy the updated source to
builddir
and the resulting package contained out-of-date code. This PR altersFPM::Cookery::Packager
so that the build and extract cookies containrecipe.revision
, if defined, in addition torecipe.name
andrecipe.version
.I also extended
SourceHandler#handler_to_class
to verify that theconst_get
lookup returns the name of a class that implementsextract
andfetch
. My test build failed because I usedsource /a/path, :with => :dir
rather thansource /a/path, :with => :directory
, andhandler_to_class
loaded the coreDir
class.One other thing -- I changed the packager to always run
FileUtils.touch(build_cookie)
-- it seems to me thatRecipe#build
shouldn't need to returntrue
in order to indicate a successful build; anything that doesn't raise an exception should be fine.