search

bernd / fpm-cookery

A tool for building software packages with fpm.
Other
460 stars 88 forks source link

allowing newer version of puppet #211

Closed gmathes closed 2 years ago

gmathes commented 4 years ago

I am starting to build packages for Ubuntu 20 (Focal Fossa). Puppet does not seem to support Ubuntu 20 with version 5 and below. This change allows Puppet 6 to be installed.

Error on Ubuntu 20:

/var/lib/gems/2.7.0/gems/puppet-5.5.20/lib/puppet/resource/catalog.rb:232:in `apply': uninitialized constant Puppet::Util::Storage (NameError)
    from /var/lib/gems/2.7.0/gems/puppet-5.5.20/lib/puppet/indirector/resource/ral.rb:38:in `save'
    from /var/lib/gems/2.7.0/gems/puppet-5.5.20/lib/puppet/indirector/indirection.rb:289:in `save'
    from /var/lib/gems/2.7.0/gems/fpm-cookery-0.35.1/lib/fpm/cookery/dependency_inspector.rb:59:in `package_installed?'

Thoughts on bumping this gem? Tests appear to work and packages are building on Ubuntu 20

gmathes commented 4 years ago

@bernd, any thoughts on this change? 🙏

madelaney commented 2 years ago

@bernd bump, please ☕

oberones commented 2 years ago

@bernd we can haz merge?? :P

bernd commented 2 years ago

@gmathes I just released 0.36.0 which includes this PR. Happy packaging! :wave: