search

bernd / fpm-cookery

A tool for building software packages with fpm.
Other
460 stars 88 forks source link

Failure packaging when using fpm-cookery #23

Closed dkowis closed 11 years ago

dkowis commented 11 years ago

https://github.com/jordansissel/fpm/issues/402

I've linked it here as well, since that's what whack recommended on IRC.

dkowis commented 11 years ago

So I hacked the thing, to not explode on the name reference, but now I get an empty RPM.

Here's a recipe.rb that I'm using that duplicates the issue:

class LibYaml < FPM::Cookery::Recipe
  description 'Lib Yaml for ruby 1.9'
  name 'libyaml'
  version '0.1.4'
  revision '1'
  homepage 'http://pyyaml.org/wiki/LibYAML'
  source 'http://pyyaml.org/download/libyaml/yaml-0.1.4.tar.gz'
  sha256 '7bf81554ae5ab2d9b6977da398ea789722e0db75b86bffdaeb4e66d961de6a37'
  arch 'x86_64'
  section 'libs'

  build_depends 'rpmdevtools'

  def build
    configure :prefix => '/usr/local'
    make "jobs" => 4 
  end

  def install
    make :install, 'DESTDIR' => destdir
  end
end

Using a vagrantVM, centos 6.4

dkowis commented 11 years ago

Interestingly enough, it's an empty RPM on the master branch, but not on the released version.

andytinycat commented 11 years ago

Is the tmp-dest directory empty after running fpm-cook?

dkowis commented 11 years ago

No, but the /tmp/package-garbage directory was.

andytinycat commented 11 years ago

There's been quite a few changes since the last release. I'll see if I can replicate it.

bernd commented 11 years ago

I changed packager.rb to just require fpm instead of the separate package types. This should fix this and similar errors in the future. I also fixed the empty package problem. This was introduced by me in ab816e3.

@dkowis Can you please test again against master?

Thanks for the report!

bernd commented 11 years ago

Closing this. Please reopen if it's still an issue for you.