bernd / fpm-cookery

A tool for building software packages with fpm.
Other
460 stars 88 forks source link

fpm-cook fails to create rpm with fpm 0.4.36 #27

Closed ryansch closed 11 years ago

ryansch commented 11 years ago

0.4.35 works fine

0.4.36 gives me the following error output:

===> [FPM] Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.u8d50m {"file":"cabin/mixins/pipe.rb","line":"46","method":"block in pipe"}
===> [FPM] Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.TQZNi0 {"file":"cabin/mixins/pipe.rb","line":"46","method":"block in pipe"}
===> [FPM] Executing(%install): /bin/sh -e /var/tmp/rpm-tmp.npnxBD {"file":"cabin/mixins/pipe.rb","line":"46","method":"block in pipe"}
===> [FPM] Processing files: mosh-1.2.4.fpm1-1.x86_64 {"file":"cabin/mixins/pipe.rb","line":"46","method":"block in pipe"}
ERROR: [FPM] error: Bad syntax: %defattr(,root) {"file":"cabin/mixins/pipe.rb","line":"46","method":"block in pipe"}
===> [FPM]  {"file":"cabin/mixins/pipe.rb","line":"46","method":"block in pipe"}
ERROR: [FPM]     Bad syntax: %defattr(,root) {"file":"cabin/mixins/pipe.rb","line":"46","method":"block in pipe"}
===> [FPM]  {"file":"cabin/mixins/pipe.rb","line":"46","method":"block in pipe"}
===> [FPM] RPM build errors: {"file":"cabin/mixins/pipe.rb","line":"46","method":"block in pipe"}
WARNING: [FPM] no value for epoch is set, defaulting to nil {"file":"fpm/package/rpm.rb","line":"386","method":"epoch"}
===> Created package: /home/ryan/fpm/mosh/pkg/mosh-1.2.4.fpm1-1.x86_64.rpm
/usr/local/lib/ruby/gems/1.9.1/gems/fpm-0.4.36/lib/fpm/util.rb:56:in `safesystem': rpmbuild failed (exit code 1). Full command was:["rpmbuild", "-bb", "--define", "buildroot /tmp/package-rpm-build20130521-12426-1hruz5q/BUILD", "--define", "_topdir /tmp/package-rpm-build20130521-12426-1hruz5q", "--define", "_sourcedir /tmp/package-rpm-build20130521-12426-1hruz5q", "--define", "_rpmdir /tmp/package-rpm-build20130521-12426-1hruz5q/RPMS", "/tmp/package-rpm-build20130521-12426-1hruz5q/SPECS/mosh.spec"] (FPM::Util::ProcessFailed)
    from /usr/local/lib/ruby/gems/1.9.1/gems/fpm-0.4.36/lib/fpm/package/rpm.rb:352:in `output'
    from /usr/local/lib/ruby/gems/1.9.1/gems/fpm-cookery-0.13.0/lib/fpm/cookery/packager.rb:165:in `block in build_package'
    from /usr/local/lib/ruby/gems/1.9.1/gems/fpm-cookery-0.13.0/lib/fpm/cookery/packager.rb:124:in `chdir'
    from /usr/local/lib/ruby/gems/1.9.1/gems/fpm-cookery-0.13.0/lib/fpm/cookery/packager.rb:124:in `build_package'
    from /usr/local/lib/ruby/gems/1.9.1/gems/fpm-cookery-0.13.0/lib/fpm/cookery/packager.rb:112:in `dispense'
    from /usr/local/lib/ruby/gems/1.9.1/gems/fpm-cookery-0.13.0/lib/fpm/cookery/cli.rb:122:in `block (2 levels) in run'
    from /usr/local/lib/ruby/gems/1.9.1/gems/fpm-cookery-0.13.0/lib/fpm/cookery/cli.rb:119:in `each'
    from /usr/local/lib/ruby/gems/1.9.1/gems/fpm-cookery-0.13.0/lib/fpm/cookery/cli.rb:119:in `block in run'
    from /usr/local/lib/ruby/gems/1.9.1/gems/fpm-cookery-0.13.0/lib/fpm/cookery/book.rb:8:in `call'
    from /usr/local/lib/ruby/gems/1.9.1/gems/fpm-cookery-0.13.0/lib/fpm/cookery/book.rb:8:in `load_recipe'
    from /usr/local/lib/ruby/gems/1.9.1/gems/fpm-cookery-0.13.0/lib/fpm/cookery/cli.rb:115:in `run'
    from /usr/local/lib/ruby/gems/1.9.1/gems/fpm-cookery-0.13.0/bin/fpm-cook:7:in `<top (required)>'
    from /usr/local/bin/fpm-cook:23:in `load'
    from /usr/local/bin/fpm-cook:23:in `<main>'

The output about creating the rpm is also incorrect.

bernd commented 11 years ago

Thanks for the report, I'll have a look.

ryansch commented 11 years ago

Thanks for the fix!