Add support for PEAR packages

bernd / fpm-cookery

A tool for building software packages with fpm.

Other

460 stars 88 forks source link

Add support for PEAR packages #85

Closed mlafeldt closed 10 years ago

mlafeldt commented 10 years ago

Note on the attributes: With this PR, all attributes supported by FPM can be passed via an fpm-cookery recipe. I'm not sure if this flexibility is required or how attributes are normally handled (they're missing in most other package types).

mlafeldt commented 10 years ago

As in #87, it might be better to use the fpm_attributes helper instead of implementing every single attribute in fpm-cookery. @bernd, what to you think?

bernd commented 10 years ago

Jup, sounds good!

mlafeldt commented 10 years ago

Jup, sounds good!

Done!

mlafeldt commented 10 years ago

Reading https://github.com/bernd/fpm-cookery/pull/87#issuecomment-44944613, I think I misunderstood you. Having PEAR-specific attributes wasn't bad after all?

bernd commented 10 years ago

I would just start without any PEAR-specific attributes and only add the ones that are used frequently as attributes. Or are all of them needed every time? :smile:

mlafeldt commented 10 years ago

Fair enough. Take a look at 8d8b3bc.

bernd commented 10 years ago

Thank you!

mlafeldt commented 10 years ago

You're welcome. Now looking forward to a new gem release! :)

bernd commented 10 years ago

I just released 0.24.0 to rubygems.

mlafeldt commented 10 years ago