search

berndpfrommer / flir_spinnaker_ros2

ros2 driver for flir spinnaker SDK
26 stars 27 forks source link

Add configuration and launch files for GigE Blackfly S #13

Closed kjanesch closed 1 year ago

kjanesch commented 2 years ago

This pull request adds the GigE Vision-specific parameter to enable jumbo frames from Blackfly S cameras, as well as a launch file to set it. These cameras support a max of 9000, as do most NICs from the last decade or so.

Currently, this requires the camera have a compatible IP address already (from DHCP, persistent IP, or "Auto Force IP" set via SpinView).

Tested against BFS-PGE-23S3C cameras in Foxy.

berndpfrommer commented 2 years ago

From what I gather the python launch script fails the lint tests. Could you please run the following command (see README) and fix the test errors?

colcon test --packages-select flir_spinnaker_ros2 && colcon test-result --verbose

Thanks!

berndpfrommer commented 2 years ago

@kjanesch if you don't have the time to clean up the python lint errors I can do that under a different PR but it would mean the commits will then be under my name. Please let me know if you are ok with that.

berndpfrommer commented 1 year ago

This has been addressed now via PR #19