search

berndporr / iir1

DSP IIR realtime filter library written in C++
http://berndporr.github.io/iir1/
MIT License
627 stars 137 forks source link

Fixed several Warnings generated by clang-tidy and gcc #16

Closed sven-herrmann closed 3 years ago

sven-herrmann commented 3 years ago

New pull request, with fixed line endings. Not sure where those came from as I am solely working on Linux. Some files not initially touched by me actually showed CRLF line endings as well.

Warnings that got fixed were int to uint conversions and a few missing member variable initializations.

berndporr commented 3 years ago

Sorry but now you have converted all files to the Unix convention so that now it's even less possible for me to check where you have made changes. git diff @{1} now reports bulk changes to everything and not just the lines you have changed. Since you haven't done two commits (i.e. change to LF and then fixed the unsigned) it's impossible for me to see what you have changed as it's just one large commit. I'll change everything to unix now in the master branch but sorry cannot merge your pull request as it's not possible to track what you have done.

sven-herrmann commented 3 years ago

you can use --ignore-space-at-eol with git diff to ignore those

sven-herrmann commented 3 years ago

Additionally, --ignore-space-change ignores changes in leading white-space

berndporr commented 3 years ago

I've spent already far too much time on this fighting with your pull request. You need to make it in a way that it's directly applicable and not requiring commandline options etc. You need to make it as transparent and easily applicable as possible. I've spent too much time on it. Sorry!