berndporr / iir1

DSP IIR realtime filter library written in C++
http://berndporr.github.io/iir1/
MIT License
637 stars 140 forks source link

CMake: use cxx_std_11 compile feature instead of CMAKE_CXX_STANDARD #50

Closed SpaceIm closed 1 year ago

SpaceIm commented 2 years ago
berndporr commented 1 year ago

This moves it up a lot in the cmake version number. However, there are people who use Linux distros with cmake 3.1.0 and as long as we are using C++11 (which is 10 years old!) I'd keep it at 3.1. It's actively used and would break dependency.

SpaceIm commented 1 year ago

As you wish. You may be stuck to 3.1 for years if you want to support default CMake version of old distros (by the way users can update their CMake version, even on old distros).

nickbailey commented 1 year ago

A lot of our users don't have root privileges, so it's difficult for them to update the current cmake. The develop software as users. They would have to build a local version, which is more than trivial. I have to agree with @berndporr on this one, although normally newer is better, obviously.

berndporr commented 1 year ago

I've found this post here: https://unix.stackexchange.com/questions/535052/what-cmake-version-can-i-rely-on-in-current-popular-linux-distributions Looks like 3.8.0 seems to be OK so I've committed the changes.