Closed chiphogg closed 1 year ago
Thanks for raising the issue. It seems that conan 2.0 broke cmake-conan. https://github.com/conan-io/cmake-conan
I will adapt the CMake files accordingly.
I'm currently fixing it in the following branch, if you want to try it out. https://github.com/bernedom/SI/tree/building/make-conan-2-compatible
To build without the tests (only install and packaging instructions will be generated as SI is header only)
cmake -S . -B build
cmake --build build
To build including the tests use:
conan install . --output-folder=build --build=missing --settings=build_type=Debug
cmake -B build -S . --toolchain ./build/conan_toolchain.cmake -DCMAKE_BUILD_TYPE=Debug
cmake --build build -- -j $(nproc)
This worked for me! I was able to build all of the code. I changed one of the tests to make it fail, and I was able to figure out how to run the test, and saw that it failed.
I updated the build instructions and CI pipeline to work with conan2
Describe the bug I checked out the repo and tried to build the code and tests, so I could start playing with the library.
To Reproduce Steps to reproduce the behavior:
pip install conan
cmake ..
step fails, complaining about missingCMAKE_BUILD_TYPE
settingcmake -DCMAKE_BUILD_TYPE=Debug ..
instead. Now it complains about not having a conan profile.conan profile detect --force
Error message from step 3:
Error message from step 4:
Subset of error message from step 6:
Expected behavior I expected the step to succeed, so I could run the following command and run the tests.
Screenshots N/A
Desktop (please complete the following information):
Smartphone (please complete the following information): N/A
Additional context I am not well versed in conan and cmake; I'm rather spoiled by bazel. It's possible that I'm making some basic mistake. However, it looks like this could be consistent with the upgrade to conan 2, which I know has broken a bunch of other packages, including mp-units.