improving operators - Githubissues

bernedom / SI

A header only C++ library that provides type safety and user defined literals for physical units

https://si.dominikberner.ch/doc/

MIT License

499 stars 40 forks source link

improving operators #15

Closed Kicer86 closed 5 years ago

Kicer86 commented 5 years ago

this PR:

adds operator+= for unit_t
adds missing const for operator-
adds operator *= for scalars

bernedom commented 5 years ago

Thank you for your contribution. Please add the corresponding tests in /test/src/detail_tests/unit_t_operator_tests.cc as having the operators covered with tests greatly helps for possible refactorings later.

Kicer86 commented 5 years ago

@bernedom could you contact me via hangouts on gmail? I need some clarifications about test framework.