search

berngp / node-green-jwt

Node implementation of JSON Web Token (JWT) with support for signatures (JWS), encryption (JWE) and web keys (JWK).
Other
22 stars 7 forks source link

extend encode to accept a header extension object to allow jku, kid, xtu... #3

Closed alexahn closed 10 years ago

alexahn commented 10 years ago

..., and x5t to be set

To allow reserved (or unreserved) parameter names for the JWT header to be set (http://tools.ietf.org/html/draft-ietf-jose-json-web-signature-02#section-4.1).

berngp commented 10 years ago

Thanks @alexahn for the commits!

alexahn commented 10 years ago

Should we just bypass typ and alg? I looked briefly, and it seems the other reserved keywords are not being used in this library.

berngp commented 10 years ago

@alexahn makes sense.

berngp commented 10 years ago

Will not push to NPM yet. Need to make sure we we don't have header collisions with typ and alg and provide a tests.

alexahn commented 10 years ago

WIll do, hopefully by the end of the day!

berngp commented 10 years ago

@alexahn btw, thank you for the pull request!

alexahn commented 10 years ago

Sorry about this, I've just been really busy lately. I haven't forgotten!

berngp commented 10 years ago

@alexahn relax and take your time, no rush.