search

bernhard-42 / three-cad-viewer

A CAD viewer component based on three.js
MIT License
158 stars 28 forks source link

provide default up option #7

Closed roipoussiere closed 5 months ago

roipoussiere commented 1 year ago

The new release introduced a new bug with error cameraUp[this.up] is undefined, coming from this.pCamera.up.set(...cameraUp[this.up]); in camera.js (probably introduced in af2cfc869f0b851f4db524ecc34e5c3f82a7e112).

I had to manually set options.up = 'Z' to fix this, but I think a default value should be set.

bernhard-42 commented 1 year ago

Agreed, I had always set up in my tests. I understand you are not blocked, right?

roipoussiere commented 1 year ago

Yes I defaulted to Z, you have time: https://github.com/roipoussiere/cadquery-server/commit/1ace68a45261e43900f202540c761ae4889d5741