bernhard-42 / vscode-cadquery-viewer

A viewer for CadQuery integrated into VS Code based on three-cad-viewer
Apache License 2.0
7 stars 1 forks source link

[RETEX] Windows #3

Open Jojain opened 1 year ago

Jojain commented 1 year ago

Hello Bernard,

I have tried to install and to use your extension on Windows successfully ! I assume that your install will work on the global python interpreter ? Assuming a beginner (that has no clue of what is a venv) wants to install it, he will not have to install some kind of venv before ?

Now for my use case I started with a blank new mamba env. My setup of new envs doesn't install pip by default (and I had forgot that). So when I tried to install cq_vscode and the other libs from your extension it was failing.

Maybe adding a clear error message indicating that pip must be installed in the venv for installing the lib could help clarify the issue. (It was pretty straight forward for someone that know a bit of things works though).

I tried to change the scripts in the settings.json, the extension will take them into account only if I restart VSCode (not a big deal but I'm mentionning it in case its not expected).

FInally, for an even better beginner experience it would be create to have exemples "folders" in the extension bar to provide exemples directly from the extension. What could be interesting is :

Do you think it's doable ?

Apart from that, it just works so kudos to you for this immensly improved user starting experience !

bernhard-42 commented 1 year ago

1) I don't care whether it is an env or the global intepreter. The only prerequisite is that in VS Code the right interpeter has been selected. The extensions gets this interpreter and the calls path/to/python -m pip install ... So, no venv is needed 2) mamba -> fair. While cadquery can be installed with mamba/conda, build123d and cq_vscode do not live in conda-forge world I will add this as a prerequisite and check for pip in the extension 3) Refresh "forgot" to reread the settings. Saw it today in the morning, already fixed 4) Examples: Good idea and I ad thought about it. But I couldn't decide which would be good examples. Any proposal?

Thanks for the kudos!