bernhard-42 / vscode-ocp-cad-viewer

A viewer for OCP based Code-CAD (CadQuery, build123d) integrated into VS Code
Apache License 2.0
78 stars 9 forks source link

Can be added to the install instructions for ARM MacOS #50

Closed lishine closed 5 months ago

lishine commented 6 months ago

On ARM Mac:

brew install miniforge

conda init "$(basename "${SHELL}")" mamba create -n code_cad python=3.10

add to the end of your shell profile ~/.zshrc conda activate code_cad run from your working folder code .

Install python extension Install OCP CAD Viewer extension -> select the quick install cudquery/build123d

bernhard-42 commented 5 months ago

Added it to the Readme

lishine commented 5 months ago

@bernhard-42 I saw you added the documentation, but it still confuses me. When I first got here, I was overwhelmed. But the thing is that it is very very simple.

That confuses me:

Necessary tools:
python and pip available in the Python environment that will be used for CAD development

As if I need to install pipe or python, I don't.

And the arm instructions, it says go back to #1. It confuses.

As a user I want start the page with 3 titles - windows/Linux/mac/mac-arm. Mac and mac arm can have the list of instructions that I wrote above and it will be very simple , otherwise it puts off.

BTW I think this is important:

add to the end of your shell profile ~/.zshrc
conda activate code_cad

Otherwise env not activated

bernhard-42 commented 5 months ago

well, without python and pip nothing works. And they are not installed on every platform by default ...

Unfortunately your instructions are not fully consistent. It doesn't make sense to use a command to identify the shell and then later add something to .zshrc (I for example do not use zsh but bash).

And you definitely do not want to add the activation of your env to your zshrc. Most people work with many envs and activate the one they need ad hoc.

Hence I think my description is a bit more consistent and much more generic. If you only work with one env, do what you described. But we can't add that to the Readme.

lishine commented 5 months ago

well, without python and pip nothing works.

Of course it will work. Python and pip will work from the venv. No need the global ones. By default shell not activates venv and then it will use the global ones instead of erroring , which is what I suggest preventing by not installing global ones. It is not essential and moreover confusing. I am telling you that I am as a typescript programmer coming to this extension , looked at the instructions, was overwhelmed and thought I would have to compile from source or something... As a Mac and typescript user , I want to see easy few lines of straight instructions. I mean that will ease bringing users.

bernhard-42 commented 5 months ago

I got asked by users to add this statement, because they e.g. didn't have pip installed. They were confused. Hence I added it. So, what is confusing or not depends on the user :-)

lishine commented 5 months ago

😅