search

bernhard-42 / vscode-ocp-cad-viewer

A viewer for OCP based Code-CAD (CadQuery, build123d) integrated into VS Code
Apache License 2.0
78 stars 9 forks source link

Settings parameter KEEP_PANEL_OPEN to not close the terminal #61

Closed 42sol-eu closed 3 months ago

42sol-eu commented 4 months ago

In some use-cases it is not the intended behaviour of the user to let OCP-View close the terminal panel.

Expected behaviour:

if new parameter KEEP_PANEL_OPEN =false : OCP-viewer will close the output/terminal panel if new parameter KEEP_PANEL_OPEN =true : OCP-viewer will not touch the sate of the output/terminal panel

42sol-eu commented 4 months ago

My use case is to call python scripts from the terminal. the closing of the terminal is therefore unintended, though only a tiny anoyance

Thanks for your great work on the viewer itself. I really value your time and effort. If you are ever near Kassel - you can contact me for a small tour and a free lunch

bernhard-42 commented 4 months ago

Had already planned to make it configurable (since I also don't like the bevavior any more) It is useful for people with smaller screens, hence I will introduce a VS Code workspace config (no need to use set_defaults)

bernhard-42 commented 4 months ago

Glad you like it and thanks for the offer😀

bernhard-42 commented 3 months ago

fixed in 2.2.2