search

bernhardh / nova-dynamic-views

A nova package for dynamically overwrite the custom placeholders
16 stars 9 forks source link

Fix nova 4 support #15

Closed mark-b-ab closed 2 years ago

bernhardh commented 2 years ago

Thanks for your PR! I don't have nova 4, so I can't test ist atm. But why this PR? I merged another a couple of months ago just to add these lines of code. See https://github.com/bernhardh/nova-dynamic-views/pull/12

Marko298 commented 2 years ago

You haven't imported Request from \Request

Marko298 commented 2 years ago

It crashes if you try to install

bernhardh commented 2 years ago

So the solution would be, to import it, right? Can you test it and change your PR? As I said, I have no nova 4, so I cant test it. In Nova 3, I don't need this method at all, so I am on a fixed branch

bernhardh commented 2 years ago

In master branch, there was already the correct namespace. I don't know why, it wasn't in 1.5.0. Now in 1.5.1 I have added it.

But I don't think it works, even after this fix. There is no error, but the toolbar isn't shown. I have no clue and at the moment no time to fix this. Maybe something changed internally in nova4. To be honest, the toolbar logic of nova is very bad (or was at least for version 3), thats why I created this package in the first place. Since I switched to the way better filamentphp as an admin panel, I don't use nova anymore.

If you find a solution, you can create an PR.

Marko298 commented 2 years ago

Got it, thanks for your time!