search

bernhardh / nova-translation-editor

A laravel nova translation editor
12 stars 14 forks source link

bug: horizontal scroll with multiple languages and multiple groups #1

Closed ibrunotome closed 3 years ago

ibrunotome commented 3 years ago

It's easy to add a fix to have horizontal scroll inside the main part?

Screen Shot 2020-12-12 at 22 03 19
bernhardh commented 3 years ago

I am working on it and already have a solution for it.

bernhardh commented 3 years ago

Please see v1.2.0 with horizontal scrollbars if needed and some other nice improvements like global filters. Would be nice to get feedback.

Should now look like this:

image

ibrunotome commented 3 years ago

The scrollbar is working great and the global search is fast! 👏

Screen Shot 2020-12-14 at 07 44 49

But the error on save still exists, even with the model configured on the spatie settings, that's because this line is using the original LanguageLine model instead of the configurable model https://github.com/bernhardh/nova-translation-editor/blob/850199c851a5f04b127059acb293533e8d94ee54/src/NovaTranslationEditorController.php#L76

bernhardh commented 3 years ago

Uh. Sorry, didn't thought I was using the Model there "hardcoded". I would accept a PR or otherwise I would fix it in the next days.

bernhardh commented 3 years ago

You last post is actually for #2 closing this issue