search

bernhardh / nova-translation-editor

A laravel nova translation editor
12 stars 14 forks source link

Tool's CSS files are causing issues in Nova 4 #14

Closed canvural closed 2 years ago

canvural commented 2 years ago

Hello,

I'm in the middle of upgrade process to Nova 4.

One thing I noticed is that when I include this tool, it causes issues overall in the design of Nova.

With this tool enabled: image

Without the tool: image

When I check the CSS from devtools I can see the CSS from this tool overwrites some values from Nova.

I'm sorry I do not have more information about this. If you are not able to reproduce this, please let me know what information you need.

bernhardh commented 2 years ago

Sorry, I don't use nova anymore. If you find the issue yourself, please make a pull request, so that we can fix it for other users.

canvural commented 2 years ago

I think the issue is this tool provides it's own Tailwind css: https://github.com/bernhardh/nova-translation-editor/blob/f752ece8bb6a0fc6f43e9de19ace33b857824c6e/resources/css/tool.css

@bernhardh Can we remove the contents of tool.css ? It looks wrong to provide another Tailwind since Nova already imports it. tool.css should just be for project specific CSS

bernhardh commented 2 years ago

Yes, why not. Try it out, if it works and that it don't break anything, then you could create a pull request.

You will have to remove it from

https://github.com/bernhardh/nova-translation-editor/blob/f752ece8bb6a0fc6f43e9de19ace33b857824c6e/src/NovaTranslationEditor.php#L21

https://github.com/bernhardh/nova-translation-editor/blob/f752ece8bb6a0fc6f43e9de19ace33b857824c6e/webpack.mix.js#L9

as well and recompile it with npm run prod.