search

bernhardh / nova-translation-editor

A laravel nova translation editor
12 stars 14 forks source link

bug: english translations of global (*) group not being saved #4

Closed ibrunotome closed 3 years ago

ibrunotome commented 3 years ago

Anything typed on english column of global group (*) is ignorated, I can't find the problem 🤔

Screen Shot 2020-12-15 at 07 33 32
ibrunotome commented 3 years ago

Found something: I have 63 translations of group * saved in database.

Screen Shot 2020-12-15 at 07 59 38

But the editor is loading the translations that are in /lang/pt-BR.json and /lang/vendor/nova/pt-BR.json into the * group too, and once the save button is pressed, they are saved into database too. Is there a way to make this optional? these /lang/pt-BR.json and /lang/vendor/nova/pt-BR.json or any default .json will never be modified through the panel by us.

One dumb fix that I can make right now is not use * for this 63 rows 🤔

ibrunotome commented 3 years ago

Done, renamed * to t-global and everything is working, closing the issue.

Screen Shot 2020-12-15 at 22 49 03
bernhardh commented 3 years ago

Yeah. Its not the best idea to name a key with * (or any other none alphanumeric character).