search

bernhardh / nova-translation-editor

A laravel nova translation editor
12 stars 14 forks source link

Json translation files group "*" #7

Closed andrius-urb closed 3 years ago

andrius-urb commented 3 years ago

As in https://github.com/spatie/laravel-translation-loader#usage mentioned: image

But this editor does not support this kind of config image

It shows zero results for group "*" image

Group with name "*" needed to override .json translation files. Can this be fixed ?

andrius-urb commented 3 years ago

UPDATE: As I've tested, https://github.com/bernhardh/nova-translation-editor/blob/master/src/NovaTranslationEditorController.php#L35 this one does not return array for *(I have records in database with group = *), it returns same string *. Any other group which does not exist returns its name.

bernhardh commented 3 years ago

I am not sure - what should be stored in the * group?

andrius-urb commented 3 years ago

In group "*" should be stored all translations, that are in .json files.

bernhardh commented 3 years ago

Yes, but I can't build a gui for this, since the json structure isn't predictable. It could have also nested properties, which have other nested properties. Thats not really representable by a table based gui.

Sorry, its a won't fix.