bernie-g / geckolib

GeckoLib is an animation engine for Minecraft mods, with support for complex 3D keyframe-based animations, numerous easings, concurrent animation support, sound and particle keyframes, event keyframes, math-based animations, and more. Available for all major modloaders.
https://geckolib.com
MIT License
610 stars 127 forks source link

Iris Shader with Entity Shadows break entity animations using Geckolib 4.2.4 #512

Closed NolanHewitt closed 10 months ago

NolanHewitt commented 1 year ago

With entity shadows on animations from mods using this lib will not play, but as soon as entity shadows are disabled animations work again. Using the 4.2.4 fabric version of geckolib for 1.20.1

Tslat commented 1 year ago

Excellent.. good to know we just can't win with shaders lol

SaltSouls commented 1 year ago

Same thing is happening with Oculus on forge 1.20.1 with geckolib 4.2.1-4.2.4.

necromancerpigeon commented 1 year ago

I had a similar issue in which my horse from SWEM mod started to T pose until i turned of the shadows on Complementary Shaders.

It seem downgrading to 4.2.3 fixed it.

BTW I am using ( Oculus + Embeddium )

edit: nevermind the bug is back.

ZsoltMolnarrr commented 12 months ago

Confirm, this is a major issue.

SiverDX commented 11 months ago

you may already know this but something about invoking the entity renderer twice is the problem

https://github.com/IrisShaders/Iris/blob/e8a625222920f9b9e8249b7adb285a83abf9bbda/src/main/java/net/coderbot/iris/pipeline/ShadowRenderer.java#L498-L502

example on what it looks like with oculus

image

Tslat commented 11 months ago

Yeah that's pretty much expected

The issue is we don't know why that's causing them to lock up yet

justsomedragon commented 10 months ago

can confirm. noticed this issue with Naturalist mod today, all naturalist mob animations seem to break when iris shaders are enabled. i've been having this issue with a few playthroughs recently so figured i'd contribute to the post, hope this helps. (also sorry if this is the wrong place to post, i am not familiar with github)

mc: 1.20.1 fabric: 0.15.3 geckolib: 4.3.1

zanyahtzee commented 10 months ago

looks like there's a fix out

SiverDX commented 10 months ago

that seems to just re-introduce this https://github.com/bernie-g/geckolib/commit/6204ee15862052ac63f79e2759f7ea92c9bed4c8

and there was probably a reason why it was removed

Tslat commented 10 months ago

Try 4.4

NolanHewitt commented 9 months ago

Version 4.4 looks like it fixed this issue! Thank you.