search

bernie-g / geckolib

GeckoLib is an animation engine for Minecraft mods, with support for complex 3D keyframe-based animations, numerous easings, concurrent animation support, sound and particle keyframes, event keyframes, math-based animations, and more. Available for all major modloaders.
https://geckolib.com
MIT License
609 stars 127 forks source link

Fix Forge compatibility #590

Closed danorris709 closed 4 months ago

danorris709 commented 4 months ago

This moves the networkProtocolVersion call before the optional call which allows Forge clients to connect to servers.

The reason this needs to go first is because the optional call uses the default value for the network protocol version, which is 0, and then the following network protocol version doesn't update (or wipe) the previously assigned network acceptance tests.

image

Not sure if there's anything else to test to ensure this is working on Forge 1.20.6

Tslat commented 4 months ago

It's disgusting that this is even a thing

Thanks though lol