bernie-g / geckolib

GeckoLib is an animation engine for Minecraft mods, with support for complex 3D keyframe-based animations, numerous easings, concurrent animation support, sound and particle keyframes, event keyframes, math-based animations, and more. Available for all major modloaders.
https://geckolib.com
MIT License
609 stars 127 forks source link

[1.21] Buffer Builder Not Building! with glowing item/armor render layers on 4.5.7 #606

Closed iron431 closed 2 months ago

iron431 commented 3 months ago

Neoforge 1.21 21.0.103-beta Geckolib 4.5.7 https://gist.github.com/iron431/05bb9914a6cf994e82f77e48176a9212

GeoEntities with an ItemArmorGeoLayer or BlockAndItemGeoLayer will throw the Not Building! error when attempting to render the items/armor if the entity is glowing, seemingly due to the buffer while glowing failing the instanceof BufferBuilder check. Other render layers that render custom models do not experience this issue

image

JaisDK commented 2 months ago

Is this supposed to have been fixed? it still happens on 4.5.8 https://mclo.gs/ZXVS32O

Tslat commented 2 months ago

Is this supposed to have been fixed? it still happens on 4.5.8 https://mclo.gs/ZXVS32O

Does it happen without Embeddium enabled

djnifos commented 2 months ago

Got a user to remove embeddium and it still happens https://mclo.gs/yiQ2A7l

Tslat commented 2 months ago

This is proving to be rather an annoying bug lol

Tslat commented 2 months ago

Got a user to remove embeddium and it still happens https://mclo.gs/yiQ2A7l

@djnifos Can you try this without any mods other than irons spellbooks & geckolib?

You have a lot of mods that could be interfering

SolarNightx commented 2 months ago

I tried with only downloading Gecko and Iron's and I got the same result: https://mclo.gs/gMNpJ03

djnifos commented 2 months ago

https://mclo.gs/eGM9nxm

an hs_err_pid log from this issue

Tslat commented 2 months ago

This error will not generate an hs_err_pid, that is an unrelated error

djnifos commented 2 months ago

My bad. I saw similar wording and jumped to the conclusion.

djnifos commented 2 months ago

I should add, I was leaning towards driver issue because it doesn't seem to effect my machine.

Tslat commented 2 months ago

Lol alright Let's try this once more

this should be fixed once more in 4.6