[1.20.1] Invis entities aren't translucent when they should be visible to a player

bernie-g / geckolib

GeckoLib is an animation engine for Minecraft mods, with support for complex 3D keyframe-based animations, numerous easings, concurrent animation support, sound and particle keyframes, event keyframes, math-based animations, and more. Available for all major modloaders.

https://geckolib.com

MIT License

609 stars 127 forks source link

[1.20.1] Invis entities aren't translucent when they should be visible to a player #611

Closed FlashFyreMods closed 2 months ago

FlashFyreMods commented 3 months ago

To reproduce:

Throw an invisibility potion on any vanilla LivingEntity, and the same on a geckolib LivingEntity such as the bike
Change to spectator gamemode
See that the vanilla living entity is translucent and the geckolib one is fully opaque

I think this is because GeoEntityRenderer doesn't have the functionality that is in LivingEntityRenderer#getRenderType (which makes sense as GeoEntityRenderer isn't exclusive to living entities, but still, it seems like an oversight).

Tslat commented 2 months ago

It's actually not

Using the same rendertype as vanilla still makes it render opaque, which is very curious I'll have to work out why that is

Tslat commented 2 months ago

Nvm found it lol