bernigaud / googlecl

Automatically exported from code.google.com/p/googlecl
0 stars 0 forks source link

send xoauth_displayname #41

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Start a command for a new user
2. Follow the link
3. On the approval page notice this message: "The site anonymous is requesting 
access to your Google Account for the product(s) listed below."

What is the expected output? What do you see instead?

Instead of "site anonymous" it should say something like "application googlecl".

What version of the product are you using? On what operating system?

0.9.5, Hardy 64

Please provide any additional information below.

You should probably use the xoauth_displayname parameter. See section 
"Identifying your application to users":
http://code.google.com/apis/accounts/docs/OAuth.html#tokensIdentifying

Original issue reported on code.google.com by marius.s...@gmail.com on 18 Jun 2010 at 7:53

GoogleCodeExporter commented 9 years ago
+1 on this.  The "site anonymous is requesting access to your Google Account" 
message kinda freaked me out at first.

Original comment by MarkRo...@gmail.com on 18 Jun 2010 at 8:00

GoogleCodeExporter commented 9 years ago
It might even be a good idea to send the name of the user (as the access token 
is stored in ~/.googlecl).

So something like:

"application googlecl user root"

Original comment by mjbauer95 on 18 Jun 2010 at 9:49

GoogleCodeExporter commented 9 years ago
Excellent! I missed this bit of documentation. Thanks all.

Original comment by tom.h.mi...@gmail.com on 18 Jun 2010 at 10:05

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r231.

Original comment by tom.h.mi...@gmail.com on 18 Jun 2010 at 10:13

GoogleCodeExporter commented 9 years ago
Here's a patch. It needs to be applied to the script "google" as well as the 
module googlecl.service.

If you try out the patch, feel free to make suggestions for the style of the 
display name.

Original comment by tom.h.mi...@gmail.com on 18 Jun 2010 at 10:18

Attachments:

GoogleCodeExporter commented 9 years ago
One comment, based on just looking at the patch:

For display name, use only the application name, GoogleCL, don't add the email 
address there. Account name should be solved by Issue 26, I will try to add 
some pointers there.

Original comment by marius.s...@gmail.com on 18 Jun 2010 at 10:39