Bug: Re-Review in approval although not submitted

[berntpopp]

Description

In the re-review process for lamb1, there seems to be an issue. The entity lamb1 is appearing in the approval list prematurely, before it has been officially submitted for approval by the reviewer.

Steps to Reproduce

1. Navigate to the re-review section.
2. Observe the appearance of lamb1 in the approval list.
3. Confirm whether lamb1 has been submitted for review.

Expected Behavior

Entities should only appear in the approval list post-submission for re-review.

Actual Behavior

The entity lamb1 is visible in the approval list before submission, indicating a potential flaw in the submission or listing process.

Additional Context

This issue may affect the workflow and efficiency of the re-review process, necessitating a prompt fix.

[berntpopp]

This is actually true for all genes. The status "re_review_submitted" and "re_review_approved" are only tracked in the table re_review_entity_connect. In the standard curation approval views all status and reviews are displayed which casues this "bug". This is also related to the problem of "re_review_approved" not being saved as some curators do not use the dedicated approval view for that.

[berntpopp]

Possible fix in logic:

• check for each status or review if it is in the "re_review_entity_connect" table. Show a info for the curator that this is actually part of the re-curation.
• fix the re_review_entity_connect table by adding the re_review_approved status based on some logic (e.g. the current status and revioew are primary and it is amrked as submitted