search

beroukhim-lab / BISCUT-py3

9 stars 5 forks source link

Clean up package structure and optimize script #5

Open jeff-mandell opened 9 months ago

jeff-mandell commented 9 months ago

Hi, Thanks for making this package. I develop integrative methods to quantify cancer evolution (see https://townsend-lab-yale.github.io/cancereffectsizeR/index.html), and your armSCNA peak-finding algorithm and fitness measure will likely be useful for my work.

In going through your code, I saw that the GEV calculations could be optimized to make the algorithm run a lot faster. After making the change, I'm able to run the pan-cancer analysis in a few minutes on a single core, compared to several hours on multiple cores. The codebase could also be improved by restructuring the file organization to match a standard R package (which would enable simpler installation), and it would also be nice if a lot of hard-coded options and file directories were changed so that default outputs don't go into the package directory itself.

If I make a version with these changes, would you be willing to review a pull request?

Thanks, Jeff

shahab-sarmashghi commented 9 months ago

Hi Jeff,

I'd love to see such improvements in running time and codebase/UI, and I'm sure the whole community will benefit from that. That being said, let me first discuss this internally before you put more efforts into this. This might take a week or two but I will surely get back to you.

Best, Shahab

shahab-sarmashghi commented 8 months ago

@jeff-mandell we welcome your contribution. I'll be more than happy to review your PR and accept it after some testing to make sure the algorithm works as expected.

jeff-mandell commented 8 months ago

Great, I will try to have something over by next week.

jeff-mandell commented 7 months ago

I created a pull request; see #6.

jeff-mandell commented 6 months ago

Hi @shahab-sarmashghi, is there anything I could do that would be helpful in facilitating review of the pull request? There's no rush on my end, although eventually it would be nice to point people to the original package rather than my fork

shahab-sarmashghi commented 6 months ago

Hi @jeff-mandell, sorry I've just been very busy. Will try to get through these in the next week or two.