search

berrberr / streamkeys

Global media player hotkeys for chrome
MIT License
544 stars 232 forks source link

Default Hotkeys #23

Closed ksufinger closed 9 years ago

ksufinger commented 10 years ago

I don't use the default hotkey settings, and it reverts do default every time the extension is updated. Is there any way to prevent this?

inverse commented 10 years ago

I've noticed this as well. Would be great if there was some upgrade path to persist settings.

berrberr commented 10 years ago

That is strange... should not be happening. The way that Chrome is supposed to work is any user defined hotkey > extension defined default. Do you guys remember if this has happened before, or was it just for last update? Also what OS and Chrome version are you on?

For this update I did change the default hotkeys for Mac to the media keys, but according to Chrome docs even updated default keys have lower precedence than user defined ones. Let me know the details...might be a Chrome bug!

inverse commented 10 years ago

I've noticed it a few times. Perhaps it's when Chrome updates? When It next happens I'll try to observe the exact happenings.

Windows 8.1 currently running 38.0.2125.101 m (64-bit)

ksufinger commented 10 years ago

I've been using streamkeys for a little over a month, and I've had the same issue with each update. Windows 7 64-bit, Chrome 39.0.2171.13 beta-m (64-bit)

berrberr commented 10 years ago

Thanks. This sounds like it could be a Chrome bug...user defined hotkeys are supposed to never be overwritten. Additionally, in previous updates the default hotkeys were not changed and in those cases user defined hotkeys should certainly never be overwritten. Unfortunately if it is a Chrome bug then there is not much that can be done from the extension side :frowning: I'll do some more research into this and probably end up filing a Chrome bug.

berrberr commented 10 years ago

Yep, looks like a Chrome bug: https://code.google.com/p/chromium/issues/detail?id=421482

inverse commented 10 years ago

Aha - looks like it indeed!

berrberr commented 10 years ago

I fixed this! https://code.google.com/p/chromium/issues/detail?id=421482

The patch should make it's way into tonight's canary build, and eventually beta/stable. I'll keep this open until it is up on beta channel at least.

inverse commented 10 years ago

:+1: sweet!

ksufinger commented 10 years ago

Awesome! Nice job in tracking down the issue too, thought it was interesting that the bug was specific to media assigned hotkeys. :+1:

inverse commented 9 years ago

Closable?