Bug: Properly report CORS preflight request errors

[barelylit]

Since the latest update, i am getting:

An error happend while executing a GET request to http://xxxxxxxxxxxxxxxxxxxxxxxx

Status: 0

Response:

The end point is a flask app, ans is returning 200 for sure, the line of code for the function end is:

return '200 - OK', 200

[berrnd]

Nothing about how GET requests are executed has changed in the latest release, just the fact that errors are now visible, before any error was just silently ignored. So are you sure the exact same GET request worked before for real?

 

the line of code for the function end is

What should "the line" exactly refer to?

  I can't really help without having a reproducible example. Personally I use this extension daily multiple times since years and it works and at the end any error is just about the receiver side of the corresponding request definition.

[berrnd]

A quick hint how to get more information on the failed request:

Ctrl + Shift + J to open the Browser Console, check if something pops up there while executing the Send Link action.

[barelylit]

Oh its still working, the data is still being processed by the receiving end perfectly, just i get a popup of this error appearing now.

Could it possibly be made as a configurable option to show errors or not?

Response comes back perfectly in a rest client API tester extension:

[berrnd]

Response comes back perfectly in a rest client API tester extension

Well, this Add-on isn't "a rest client API test extension". So something clearly goes wrong. Have you checked the Browser Console for further hints what's going on as mentioned in my previous message above?

Code ref how this Add-on checks for if the request succeeded: https://github.com/berrnd/send-link/blob/0179e1edd8399fe3f88c4dd8ff36b3f9ccb123ca/background.js#L61-L77

 

Could it possibly be made as a configurable option to show errors or not?

Of course that's technically possible. But I don't get why any error should be just ignored - exactly that was a big problem before last week.

[barelylit]

Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at <>. (Reason: CORS header ‘Access-Control-Allow-Origin’ missing). Status code: 200.

[barelylit]

Ive enabled CORS on the flask app, and all good now

[berrnd]

Great.

However, now that this Add-on can report errors let's track here to somehow also report problems when the CORS preflight request failed since I guess that's often a problem. Interesting though that the "real" request got through anyways for your example...