search

berserktech / telebot

Telegram bot for our community
MIT License
6 stars 1 forks source link

Rewrite: modular approach #7

Closed ghostbar closed 5 years ago

ghostbar commented 5 years ago

Fixes #3

sadasant commented 5 years ago

This is the problem that CircleCI is having: https://github.com/golang/go/issues/27056 I'm also having this myself. On it...

sadasant commented 5 years ago

IMPORTANT: This doesn't work on Zeit.co. They use an older version: https://github.com/zeit/now-builders/blob/master/packages/now-go/go-helpers.js#L93 and they disable GO111MODULE by default due to having GO111MODULE=auto.

I can manually set GO111MODULE to on, but 1.11 doesn't know how to mix go.mod with dependencies in GOPATH, see: https://golang.org/doc/go1.12#modules

... the go command now supports module-aware operations outside of a module directory, provided that those operations do not need to resolve import paths relative to the current directory or explicitly edit the go.mod file. ...

I did the silliest of pull requests to zeit/now-builders just to bring awareness to the issue: https://github.com/zeit/now-builders/pull/247

ghostbar commented 5 years ago

Going back to single-module repo for Zeit :-)